On Thu, Dec 17, 2009 at 2:32 PM, Thomas Anders <thomas.and...@blue-cable.de> wrote: > > bvass...@users.sourceforge.net wrote: > > Revision: 17913 > > http://net-snmp.svn.sourceforge.net/net-snmp/?rev=17913&view=rev > > Author: bvassche > > Date: 2009-12-17 13:05:53 +0000 (Thu, 17 Dec 2009) > > > > Log Message: > > ----------- > > Converted starttime from a global variable into a static variable and > > applied the following changes: > > - Added two new macros: NETSNMP_TIMERADD() and NETSNMP_TIMERSUB(). > > - Added three new functions: netsnmp_get_starttime(), > > netsnmp_set_starttime() and atime_hsubtract(). > > - Replaced gettimeofday() + calculate_time_diff() calls by a call to > > netsnmp_get_agent_uptime(). > > - Removed the macro DIFFTIMEVAL() because it was not used inside the > > Net-SNMP project and because it contained a bug. > > - Removed the functions calculate_time_diff(), uatime_ready(), > > marker_tticks() and timeval_tticks(). > > Could you please elaborate on the background/motivation for the last item > (removal of functions) and how this affects backwards-compatibility?
Hello Thomas, Did you notice that these changes have been applied on the trunk only and not on one of the V5.3, V5.4 or V5.5 branches ? So the removal will be effective only in a new branch (e.g. V5.6 or V6.0) at the time that branch is created. Do you think there is a realistic chance that these functions were used outside the Net-SNMP project ? How many people knew about the existence of these functions ? When you look around in the Net-SNMP source tree, you will see that few Net-SNMP contributors knew about the existence of the various timing functions in system.c and tools.c. As an example, although there was a macro in tools.h for computing the difference of two 'struct timeval' entities, and although differences between times are computed in several places, this macro wasn't used anywhere. Bart. ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
