On Fri, Apr 23, 2010 at 3:36 PM, Dave Shield <[email protected]>wrote:
> On 20 April 2010 17:37, Bart Van Assche <[email protected]> wrote: > > The patch below reenables the notification log MIB, but only when > building > > with the Windows Platform SDK enabled. > > I've had a quick look at this patch, and am currently trying out various > builds with this applied. Tests so far seem to work OK, but I've got > a couple of queries about it. > > a) The 'notification_log' object is added to the 'snmpdsdk' Makefile > (i.e. compiled into the agent binary). Whereas the equivalent > handling for the interactive MSVC build has the 'notification_log' > object included within the 'netsnmpmibssdk' project file > (i.e. compiled into the agent MIB module library). > What is the thinking behind this apparent inconsistency? > That inconsistency was unintentional -- there is no particular reason behind it. b) > > /* Define if compiling with the notification-log-mib module files. */ > > +#ifdef HAVE_PLATFORM_SDK > > +#define USING_NOTIFICATION_LOG_MIB_NOTIFICATION_LOG_MODULE 1 > > +#else > > /* #undef USING_NOTIFICATION_LOG_MIB_NOTIFICATION_LOG_MODULE */ > > +#endif > > > As far as I can tell, both the 'build.bat' and interactive MSVC builds > define > the token HAVE_WIN32_PLATFORM_SDK. > Where is the token HAVE_PLATFORM_SDK defined? > Are we certain that the resulting agent binary does indeed include the > missing Notification Log support? > Regarding the interactive build: HAVE_WIN32_PLATFORM_SDK has to be disabled manually before starting to build with MSVC 6 on a system where the platform SDK has not been installed (see also README.win32). Regarding the batch build: you should already have noticed that Platform SDK support can be enabled and disabled via menu option 2 of win32/build.bat. Bart.
------------------------------------------------------------------------------
_______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
