On Sat, Apr 24, 2010 at 11:59 AM, Dave Shield <[email protected]>wrote:
> On 23 April 2010 20:03, Bart Van Assche <[email protected]> wrote: > > Regarding the interactive build: HAVE_WIN32_PLATFORM_SDK has to be > > disabled manually before starting to build with MSVC 6 on a system where > > the platform SDK has not been installed (see also README.win32). > > I'm really not convinced about this statement. > > Firstly, the file README.win32 states that the token > HAVE_WIN32_PLATFORM_SDK needs to be explicitly *enabled* > when using the platform SDK (rather than disabled when not) > The documentation in README.win32 is correct. > Secondly, the netsnmpmibssdk.dsp project file actually includes the > compilation flag \D HAVE_WIN32_PLATFORM_SDK (while the > netsnmpmibs.dsp project file does not) > So I would expect that this definition would be set automatically, > depending on the choice of the win32 or win32sdk workspace. > (Unless I've completely misunderstood the contents of these > project files? Which is not impossible!) > But that implies to me that the README.win32 instructions are > wrong, and it shouldn't be necessary to touch the config header file. > The fact that /D HAVE_WIN32_PLATFORM_SDK is present in netsnmpmibssdk.dsp is dubious because this will result in some source files to be compiled with HAVE_WIN32_PLATFORM_SDK defined and other source files without HAVE_WIN32_PLATFORM_SDK defined. > Thirdly, both the README.win32 file and all the build environment files > talk about/work with the token HAVE_WIN32_PLATFORM_SDK. But > the patch you posted used the token HAVE_PLATFORM_SDK > (*without* the _WIN32_ element) > I wasn't sure whether this was a typo in your patch, whether there > is some subtle interaction between these two definitions, or whether > these are two completely distinct tokens (indicating something completely > different)? > That was a typo. Please let me know when you have finished reviewing this patch such that I can post a second version of this patch. Bart.
------------------------------------------------------------------------------
_______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
