>>>>> On Fri, 21 May 2010 19:04:43 -0400, Doug Manley <doug.man...@gmail.com> >>>>> said:
DM> I've submitted numerous patches to the net-snmp project for errors so DM> esoteric that it took days to find and understand them. I'd have to go back and chase the details to figure out who committed the patch, why it might have been edited, etc. If you provide a patch number I can look into it. However, comments are generally supposed to be left in with some exceptions: 1) they're not useful or are hard to understand (possibly harder than the code). 2) they're improperly formatted (though generally I'd encourage our developers to fix the formatting rather than remove them entirely). //-style comments are not acceptable in the package. We try and support as many compilers as possible, including those that aren't fully C99 compliant. And it doesn't hurt to have /* style comments instead (and for what it's worth, I'd rather use // myself but restrict my own code to /* style comments). In fact, we have a pre-release check that specifically looks for // comments and flags them as a problem. -- Wes Hardaker Please mail all replies to net-snmp-coders@lists.sourceforge.net ------------------------------------------------------------------------------ _______________________________________________ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
