On Mon, 16 Aug 2010 11:26:19 +0100 Dave wrote: DS> In general, the patch you're proposing seems sensible, DS> and I'd be happy to see it go in.
ok, so far, so good. DS> But I'd raise a minor quesion over one of your examples: d'oh! DS> > Some examples (assuming NETSNMP_DS_LIB_2DIGIT_HEX_OUTPUT is not set): DS> > DS> > Value Hint Current output Patched output DS> > 01AA02 "1x" 1AA2 01AA02 DS> DS> I'd suggest that a more natural output would be as follows: DS> DS> Value Hint Current output 2Dhex=1 2Dhex=0 DS> 01AA02 "1x" 1AA2 01AA02 1AA02 Well, a concern here is that trying to do something sensible for all cases is a bit a rats nest. Here are a few examples where the output is decidedly unsensible, but for which I have no easy fix: Value Hint Current output Patched output 01AA02 "1x1x1x" 1AA2 1AA2 (no change) 010203 "1x1x:1x" 12:3 12:03 (both incorrect) So my current patch is really a band-aid that fixes a particular case that comes up with the display hint for TLS fingerprints when the fingerprint has a byte which is less than 16. Had the display hint been written differently, I'd be up the creek with NETSNMP_DS_LIB_2DIGIT_HEX_OUTPUT as my only paddle. So, if you'd like to develop a more robust fix, I'm all for it. I'd like to go ahead an commit this fix, though, unless you think you'll come up with a more robust version before the next rc release... ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
