First, a poll:

do you think a CFV is needed for changes to non-default test scripts? i.e.
scripts that won't be run unless explicitly requested by the user?

Now the patch:

this patch:
- makes a cert name unique, since the cert util fingerprint lookup apparently
  does a prefix match, resulting in multiple fingerprints when certs have a
  shared prefix
- add a check for conf errors after starting snmpd
- add logTimestamp to conf files, to make it easier to match up command output
  with snmpd.log
- only affects tests which must be explicitly run
- only affects tests for modules which must explicitly be configured in
  (non-default code)
diff --git a/net-snmp/testing/fulltests/tls/STlsUsers b/net-snmp/testing/fulltests/tls/STlsUsers
index 57defb8..2cb03a6 100644
--- a/net-snmp/testing/fulltests/tls/STlsUsers
+++ b/net-snmp/testing/fulltests/tls/STlsUsers
@@ -76,8 +76,8 @@ CAPTURE $NSCERT gencert -t causer --with-ca ca-net-snmp.org --san email:us...@te
 CAUSERFP=`$NSCERT showcerts --fingerprint --brief causer $NSCERTARGS`
 CHECKVALUEISNT "$CAUSERFP" "" "generated fingerprint for causer certificate"
 
-CAPTURE $NSCERT gencert -t cadirect --with-ca ca-net-snmp.org --san email:use...@test.net-snmp.org --email use...@test.net-snmp.org  $NSCERTARGS
-CADIRECTFP=`$NSCERT showcerts --fingerprint --brief cadirect $NSCERTARGS`
+CAPTURE $NSCERT gencert -t cadirect9b --with-ca ca-net-snmp.org --san email:use...@test.net-snmp.org --email use...@test.net-snmp.org  $NSCERTARGS
+CADIRECTFP=`$NSCERT showcerts --fingerprint --brief cadirect9b $NSCERTARGS`
 CHECKVALUEISNT "$CADIRECTFP" "" "generated fingerprint for cadirect certificate"
 
 CAPTURE $NSCERT genca --cn ca2-net-snmp.org  $NSCERTARGS
@@ -99,6 +99,7 @@ CHECKVALUEISNT "$CADIRECT9DFP" "" "generated fingerprint for cadirect9d certific
 CONFIGAGENT '[snmp]' debugTokens tsm
 # ,tls,ssl,cert,tsm
 CONFIGAGENT '[snmp]' doDebugging 1
+CONFIGAGENT '[snmp]' logTimestamp 1
 CONFIGAGENT '[snmp]' serverCert $SERVERFP
 
 CONFIGAGENT '[snmp]' trustCert $CAFP
@@ -127,6 +128,7 @@ CONFIGAGENT certSecName 102 $CADIRECT9CFP  --sn causerdirect9cmap
 
 CONFIGAPP   serverCert  	  $SERVERFP
 CONFIGAPP   defSecurityModel      tsm
+CONFIGAPP   logTimestamp          1
 
 CONFIGAGENT  rwuser -s tsm testuser authpriv
 CONFIGAGENT  rwuser -s tsm testuser2 authpriv
@@ -151,6 +153,9 @@ FLAGS="-Dtls -v3 -On $SNMP_FLAGS $SNMP_TRANSPORT_SPEC:$SNMP_TEST_DEST$SNMP_SNMPD
 
 STARTAGENT
 
+# shouldn't have config errors
+CHECKAGENTCOUNT 0 ": Error:"
+
 ######################################################################
 # EXTENDED CERTIFICATE SETUP
 #
------------------------------------------------------------------------------
Sell apps to millions through the Intel(R) Atom(Tm) Developer Program
Be part of this innovative community and reach millions of netbook users 
worldwide. Take advantage of special opportunities to increase revenue and 
speed time-to-market. Join now, and jumpstart your future.
http://p.sf.net/sfu/intel-atom-d2d
_______________________________________________
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to