On 08/05/12 21:32, Magnus Fromreide wrote: > On Sun, 2012-08-05 at 10:41 +0000, Bart Van Assche wrote: >> [ ... ] > The above patch looks ok, so +1 for it.
Thanks ! >> [PATCH] Make get_exec_output() work on big endian systems. > > I have a hard time understanding why cachebytes and out_size have to be > able to handle negative values in order to work on big endian systems. > Could you please explain this one a little further? If sizeof(size_t) > sizeof(int), passing a 64-bit variable to a function that expects a 32-bit variable will cause the result to be written into the 32 most significant bits instead of the 32 least significant bits. So the test "cachebytes > 0" will always evaluate to true on such systems (at least if NETSNMP_MAXCACHESIZE has at least one bit set in the lower 32 bits). Bart. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
