Bart Van Assche <bvanass...@acm.org> writes:

> That patch has not been reversed. It works as follows:
> * For Unix platforms neither cygwin nor HAVE_IPHLPAPI_H are defined so
> all MIB-II tables are included.
> * When building Net-SNMP with Visual Studio, the Microsoft platform SDK
> or with MinGW then HAVE_IPHLPAPI_H is defined but cygwin not. In this
> case also all MIB-II tables are included.
> * When building with old Cygwin versions both cygwin and HAVE_IPHLPAPI_H
> are defined and also all MIB-II tables are included.
> * When building with a recent Cygwin version cygwin is defined but
> HAVE_IPHLPAPI_H not. In this case mibII/at..mibII/udp are excluded.

But I don't think that's what your patch does:

   config_require(mibII/system_mib)
   config_require(mibII/sysORTable)
  +config_require(mibII/snmp_mib)
  +config_require(mibII/vacm_vars)
  +config_require(mibII/setSerialNo)
  +#if !defined(cygwin) || defined(HAVE_IPHLPAPI_H)
   config_require(mibII/at)
   config_require(mibII/ifTable)
   config_require(mibII/ip)
  -config_require(mibII/snmp_mib)
   config_require(mibII/tcp)
   config_require(mibII/icmp)
   config_require(mibII/udp)
  -config_require(mibII/vacm_vars)
  -config_require(mibII/setSerialNo)
  +#endif

This is actually simply moving 3 requires outside the #if statement,
meaning they're *always* used.  But maybe that's actually what you
wanted (always include those particular mib modules because they're
independent of the stack).  That actually makes sense to me, but it just
didn't line up with what I thought you were stating the problem actually
was.  IE, you're trying to always include some modules.

If that's the case, then +1

-- 
Wes Hardaker
Please mail all replies to net-snmp-coders@lists.sourceforge.net

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to