On Mon, 01 Dec 2014 13:10:31 -0800 Wes wrote: WH> Bart Van Assche <bvanass...@acm.org> writes: WH> WH> > That patch has not been reversed. It works as follows: WH> > * For Unix platforms neither cygwin nor HAVE_IPHLPAPI_H are defined so WH> > all MIB-II tables are included. WH> > * When building Net-SNMP with Visual Studio, the Microsoft platform SDK WH> > or with MinGW then HAVE_IPHLPAPI_H is defined but cygwin not. In this WH> > case also all MIB-II tables are included. WH> > * When building with old Cygwin versions both cygwin and HAVE_IPHLPAPI_H WH> > are defined and also all MIB-II tables are included. WH> > * When building with a recent Cygwin version cygwin is defined but WH> > HAVE_IPHLPAPI_H not. In this case mibII/at..mibII/udp are excluded. WH> WH> But I don't think that's what your patch does:
Actually, I think it does. WH> config_require(mibII/system_mib) WH> config_require(mibII/sysORTable) WH> +config_require(mibII/snmp_mib) WH> +config_require(mibII/vacm_vars) WH> +config_require(mibII/setSerialNo) WH> +#if !defined(cygwin) || defined(HAVE_IPHLPAPI_H) WH> config_require(mibII/at) WH> config_require(mibII/ifTable) WH> config_require(mibII/ip) WH> -config_require(mibII/snmp_mib) WH> config_require(mibII/tcp) WH> config_require(mibII/icmp) WH> config_require(mibII/udp) WH> -config_require(mibII/vacm_vars) WH> -config_require(mibII/setSerialNo) WH> +#endif WH> WH> This is actually simply moving 3 requires outside the #if statement, WH> meaning they're *always* used. No, the if statement is new too. That's the part that excludes the unsupported table. The 3 required moved outside the new if are ones that still work even on new versions of cygwin.. +1 from me. ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk _______________________________________________ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
