On Wed, Mar 16, 2016 at 01:33:14PM -0400, Robert Story wrote: > On Wed, 16 Mar 2016 12:28:14 -0400 Bill wrote: > BF> > > > I think this needs some discussion. While the change does > BF> > > > not affect binary compatibility, it does remove a typedef > BF> > > > that has been around since 1998. It's possible and even > BF> > > > likely that people are using this typedef in their own > BF> > > > modules, and this will break backwards compatibility for > BF> > > > them. > BF> > > > BF> > > Restoring that typedef is easy - all that is needed is > BF> > > something like the patch below. But I'm not sure whether we > BF> > > really should restore that typedef. The name of the U64 > BF> > > type is so short that there might be other projects than > BF> > > Perl that define a conflicting type with the same name. > BF> > > BF> > Yes, but then, counter64 and oid ain't that good as names > BF> > goes either... (And yes, the perl folks are just as bad as us > BF> > when it comes to inventing good > BF> > names) > BF> > > BF> > I can surely see how both points of view have merit. > BF> > BF> Just a data point: one of the first things we did to be able to > BF> use the net-snmp client libraries was to change the net-snmp > BF> U64 typedef, since our system has its own idea of what a U64 > BF> is. (I think this is Bart's point.) > > I'm fine with changing the typedef to a new typedef (NETSNMP_U64?) > and updating all the code to use it. > > The question is whether or not compatibility is on by default. I'd > argue that in existing branches it should be, possibly with a flag > that can be defined to remove it. i.e. > > /** default to compatibility */ > #ifndef NETSNMP_U64_NOCOMPAT > #define U64 NETSNMP_U64 > #endif > > Then in future branches updating to something like > > /** do not define U64 unless requested */ > #ifdef NETSNMP_U64_COMPAT > #define U64 NETSNMP_U64 > #endif > > Thoughts?
Since c99 uint64_t exists. Why do we need U64 in the first place? /MF ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 _______________________________________________ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
