On Fri, 4 May 2018 11:40:21 -0400 Bill wrote: BF> I apologize for mis-speaking. I meant, session.localname, BF> which is used in _sess_open() as follows: BF> BF> https://sourceforge.net/p/net-snmp/code/ci/master/tree/snmplib/snmp_api.c#l1629
Ok, thanks for the pointer. So right now the only use of localname appears to be from netsnmp_create_v1v2_notification_session(). BF> I've been using and testing this code in EOS for 3 years, so BF> it's not that it's a brand new idea asking to get into rc1. BF> There could be better timing, sure, but this all unraveled from BF> me doing a better job of looking at Arista's test results BF> because rc1 is coming up, and finding that clientaddr is just BF> broken. Ok, I was wondering how long you'd had the patch and how often it was exercised. Seems like it's regular use, which is in your favor. BF> 5.8 introduces the ability to do this with BF> "trap*sink" (although as mentioned in the other thread, it BF> seems to be broken). But it's not possible to configure SNMPv3 BF> trap sinks with the "trap*sink" commands, so EOS configures all BF> of its trap destinations with "trapsess". BF> BF> If this is too esoteric, and it's not desirable to give BF> "trapsess" feature parity with "trap*sink", I can keep this BF> patch local to Arista. Or maybe since it's "feature parity" and BF> not "new feature" it can go into 5.8.1. Or I can hold onto it BF> for 5.9. I think feature parity is a good thing. How close are you to having this patch ready? I'd say create a branch for it and push it to teh SF or github repo. Seeing the actual patch will help me form my opinion on rc1 (maybe if you're quick), 5.8.1 (seams reasonable, but does it change any existing ABI?), or 5.9. Robert ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
