On Tue, Jun 12, 2018 at 11:19:04AM -0500, David Young wrote:
> On Tue, Jun 12, 2018 at 05:09:20PM +0100, Patrick Welche wrote:
> > On Tue, Jun 12, 2018 at 03:05:40PM +0100, Patrick Welche wrote:
> > > On Tue, Jun 12, 2018 at 03:02:26PM +0100, Patrick Welche wrote:
> > > > That reminds me of:
> > > > 
> > > > http://mail-index.netbsd.org/tech-net/2017/01/19/msg006248.html
> > > > 
> > > > Some feedback would have been / would be nice...
> > > 
> > > Instant feedback:
> > > 
> > > + } else if (sc->mac_ver == 0x3070 && sc->mac_rev < 0x0201) {
> > > 
> > > can't be right...
> > 
> > ... but it's in the FreeBSD driver:
> > 
> > https://svnweb.freebsd.org/base/head/sys/dev/usb/wlan/if_run.c?view=markup&pathrev=257955#l4608
> 
> At first glance, that line looks like it's performing an impossible test
> on one member of `sc`: `mac_ver` cannot both equal 0x3070 and be less
> than 0x0201.  I think that's what you mean when you say that it can't be
> right?
> 
> On second glance, there are actually two members involved: one is a
> `version` number and the other is `revision` number.

Indeed! OK - then please check out my patch :-)

Cheers,

Patrick

Reply via email to