> -----Original Message-----
> From: Sergei Shtylyov [mailto:[email protected]]
> Sent: Wednesday, December 07, 2016 2:11 AM
> To: Kirsher, Jeffrey T <[email protected]>; [email protected]
> Cc: Keller, Jacob E <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]
> Subject: Re: [net-next 20/20] i40e: don't allow i40e_vsi_(add|kill)_vlan to
> operate
> when VID<1
>
> Hello!
> > + if (!(vid > 0) || vsi->info.pvid)
>
> Why not just '!vid'?
Left over artifact of this previously being a signed value. We can fix this.
Thanks,
Jake
> > -void i40e_vsi_kill_vlan(struct i40e_vsi *vsi, s16 vid)
> > +void i40e_vsi_kill_vlan(struct i40e_vsi *vsi, u16 vid)
> > {
> > + if (!(vid > 0) || vsi->info.pvid)
>
> Likewise.
Same here. Can get this fixed.
Thanks,
Jake
>
> > + return;
> > +
> > spin_lock_bh(&vsi->mac_filter_hash_lock);
> > i40e_rm_vlan_all_mac(vsi, vid);
> > spin_unlock_bh(&vsi->mac_filter_hash_lock);
>
> MBR, Sergei
