> -----Original Message----- > From: Kirsher, Jeffrey T > Sent: Wednesday, December 07, 2016 1:53 PM > To: Keller, Jacob E <[email protected]>; Sergei Shtylyov > <[email protected]>; [email protected] > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected] > Subject: Re: [net-next 20/20] i40e: don't allow i40e_vsi_(add|kill)_vlan to > operate > when VID<1 > > On Wed, 2016-12-07 at 13:50 -0800, Keller, Jacob E wrote: > > > -----Original Message----- > > > From: Sergei Shtylyov [mailto:[email protected]] > > > Sent: Wednesday, December 07, 2016 2:11 AM > > > To: Kirsher, Jeffrey T <[email protected]>; [email protected] > > > et > > > Cc: Keller, Jacob E <[email protected]>; [email protected]; > > > [email protected]; [email protected]; [email protected]; > > > [email protected] > > > Subject: Re: [net-next 20/20] i40e: don't allow > > > i40e_vsi_(add|kill)_vlan to operate > > > when VID<1 > > > > > > Hello! > > > > + if (!(vid > 0) || vsi->info.pvid) > > > > > > Why not just '!vid'? > > > > Left over artifact of this previously being a signed value. We can fix > > this. > > > > Thanks, > > Jake > > > > > > -void i40e_vsi_kill_vlan(struct i40e_vsi *vsi, s16 vid) > > > > +void i40e_vsi_kill_vlan(struct i40e_vsi *vsi, u16 vid) > > > > { > > > > + if (!(vid > 0) || vsi->info.pvid) > > > > > > Likewise. > > > > Same here. Can get this fixed. > > While you are fixing this up and sending me a new version of this patch, I > will just drop this from the series and re-send.
Yes, since it's the last patch that's fine. Thanks, Jake
