On Sun, Dec 11, 2005 at 08:35:08PM -0800, David S. Miller wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Sun, 11 Dec 2005 18:39:32 -0800 > > > Odd net behaviour with Dave's net-2.6.16 tree. > ... > > - i cannot login with xdm, as soon as i login, the X server restarts. > > Login with startx works (.xinitrc is a symlink to .xsession) > > It works fine with 2.6.15-rc5-mm1. > > If you need any log please ask. > > > > - there is a warning when pinging an inexistent ip > > (it works fine with 2.6.15-rc5-mm1 too) > > 32-bit x86 ping binary running on an x86_64 system? That might be a > clue for the second bug. > > The first one is mysterious without some more info. > > Can you retest for the ping bug after reverting the following patch?
it fixes the ping bug and i cannot reproduce the xdm bug with the patch reverted. Is it possible that the patch touch something in the unix stream code ? It could explain why it fixes the xdm code. Thanks, Benoit > > Thanks. > > diff-tree 07dda0399dded840d4d1fde39d1cbb0b37123606 (from > 2fbe0a2c52cafa9e6533d0a1747617a46bf8bac6) > Author: Benjamin LaHaise <[EMAIL PROTECTED]> > Date: Sun Dec 11 17:28:15 2005 -0800 > > [NET]: Avoid atomic xchg() for non-error case > > It also looks like there were 2 places where the test on sk_err was > missing from the event wait logic (in sk_stream_wait_connect and > sk_stream_wait_memory), while the rest of the sock_error() users look > to be doing the right thing. This version of the patch fixes those, > and cleans up a few places that were testing ->sk_err directly. > > Signed-off-by: Benjamin LaHaise <[EMAIL PROTECTED]> > Signed-off-by: David S. Miller <[EMAIL PROTECTED]> > -- powered by bash/screen/(urxvt/fvwm|linux-console)/gentoo/gnu/linux OS - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html