> +int dsa_cpu_port_ethtool_setup(struct dsa_switch_tree *dst, > + struct dsa_switch *ds) > +{ > + struct net_device *master; > + struct ethtool_ops *cpu_ops; > + > + master = ds->dst->master_netdev;
You pass in dst as a parameter, and then don't use it! > +void dsa_cpu_port_ethtool_restore(struct dsa_switch_tree *dst, > + struct dsa_switch *ds) > +{ > + struct net_device *master; > + > + master = ds->dst->master_netdev; Same here. Andrew