Re: [PATCH net-next v3 5/6] net: dsa: Initialize CPU port ethtool ops per tree

[Florian Fainelli]

On 06/07/2016 02:51 PM, Andrew Lunn wrote:
>> +int dsa_cpu_port_ethtool_setup(struct dsa_switch_tree *dst,
>> +                           struct dsa_switch *ds)
>> +{
>> +    struct net_device *master;
>> +    struct ethtool_ops *cpu_ops;
>> +
>> +    master = ds->dst->master_netdev;
> 
> You pass in dst as a parameter, and then don't use it!

I do use it here:

        memcpy(&dst->master_ethtool_ops, master->ethtool_ops,
               sizeof(struct ethtool_ops));

> 
>> +void dsa_cpu_port_ethtool_restore(struct dsa_switch_tree *dst,
>> +                              struct dsa_switch *ds)
>> +{
>> +    struct net_device *master;
>> +
>> +    master = ds->dst->master_netdev;
> 
> Same here.

and here:

        master->ethtool_ops = dst->master_orig_ethtool_ops;

I sure could simplify that and use ds->dst instead if you find it more
elegant, works for me.
-- 
Florian