> Currently, we can have high order page allocations that specify
> GFP_ATOMIC when configuring multicast MAC address filters.
> For example, we have seen order 2 page allocation failures with
> ~500 multicast addresses configured.
> Convert the allocation for the pending list to be done in PAGE_SIZE
> increments.
> Signed-off-by: Jason Baron <jba...@akamai.com>

While I appreciate the effort, I wonder whether it's worth it:

- The hardware [even in its newer generation] provides an approximate
based classification [I.e., hashed] with 256 bins.
When configuring 500 multicast addresses, one can argue the
difference between multicast-promisc mode and actual configuration
is insignificant.
Perhaps the easier-to-maintain alternative would simply be to
determine the maximal number of multicast addresses that can be
configured using a single PAGE, and if in need of more than that
simply move into multicast-promisc.

 - While GFP_ATOMIC is required in this flow due to the fact it's being
called from sleepless context, I do believe this is mostly a remnant -
it's possible that by slightly changing the locking scheme we can have
the configuration done from sleepless context and simply switch to
GFP_KERNEL instead.

Regarding the patch itself, only comment I have:
> +                     elem_group = (struct bnx2x_mcast_elem_group *)
> +                                  elem_group->mcast_group_link.next;
Let's use list_next_entry() instead.

Reply via email to