> I tested this series on the Topaz switch but it failed because while I > said we read 0x1410C00 actually we read 0x01410C01. With the > MARVELL_PHY_ID_MASK we mask the 4 lower bits so that's why in my patch > "phy: marvell: Add support for the PHY embedded in the topaz switch" I > used the 0x01410C00 value for MARVELL_PHY_ID_88E6141.
O.K. The lower 4 bits seem to be the silicon revision. Marvells own SDK ignores those bits. So lets do the same here, use MARVELL_PHY_ID_MASK. Andrew