On 3/30/17 8:12 PM, Wangnan (F) wrote:

On 2017/3/31 10:57, Alexei Starovoitov wrote:
On 3/30/17 7:53 PM, Wangnan (F) wrote:
I suggest using a CONFIG option to enable/disable code in
test_run.o to reduce attack plane.

attack plane? what attack do you see and how config helps?

I think all testing features are not required to be compiled
for a production system. A feature which should never be used
looks dangerous to me.

It is required on production system, since xdp testing and
xdp production has to use the same kernel. We cannot
keep rebooting the server back and forth to test and then to run.
It's not testing the kernel features, it's testing bpf programs
which are technically user space components.

I suggest adding a CONFIG option like CONFIG_BPF_PROGRAM_TEST_RUN
to control whether the kernel should be compiled with this feature
or not. We can enable by default, and give people a chance to
turn it off. At least in my company people tends to turn all
unneeded features off. If you don't provide a config option they
will make one by themselves.

Using this logic huawei should be turning off xdp as well.
Sorry we're not going stub xdp facility out of the core
and the drivers just because you don't use it.

Reply via email to