Good stuff. Question below: On 17-04-25 04:06 AM, Jakub Kicinski wrote:
Try to carry error messages to the user via the netlink extended
[..]
+nfp_net_check_config(struct nfp_net *nn, struct nfp_net_dp *dp, + struct netlink_ext_ack *extack) { /* XDP-enabled tests */ if (!dp->xdp_prog) return 0; if (dp->fl_bufsz > PAGE_SIZE) { - nn_warn(nn, "MTU too large w/ XDP enabled\n"); + NL_SET_ERR_MSG(extack, "MTU too large w/ XDP enabled");
So are we going to standardize these strings? i.e what if some user has written a bash script that depends on this string and it gets changed later. cheers, jamal