On 7/19/17 1:02 AM, Jiri Pirko wrote: > @@ -879,6 +891,8 @@ static int fib6_add_rt2node(struct fib6_node *fn, struct > rt6_info *rt, > *ins = rt; > rt->rt6i_node = fn; > atomic_inc(&rt->rt6i_ref); > + call_fib6_entry_notifiers(info->nl_net, FIB_EVENT_ENTRY_ADD, > + rt); > if (!info->skip_notify) > inet6_rt_notify(RTM_NEWROUTE, rt, info, nlflags); > info->nl_net->ipv6.rt6_stats->fib_rt_entries++; > @@ -906,6 +920,8 @@ static int fib6_add_rt2node(struct fib6_node *fn, struct > rt6_info *rt, > rt->rt6i_node = fn; > rt->dst.rt6_next = iter->dst.rt6_next; > atomic_inc(&rt->rt6i_ref); > + call_fib6_entry_notifiers(info->nl_net, FIB_EVENT_ENTRY_REPLACE, > + rt); > if (!info->skip_notify) > inet6_rt_notify(RTM_NEWROUTE, rt, info, NLM_F_REPLACE); > if (!(fn->fn_flags & RTN_RTINFO)) { > @@ -1459,6 +1475,7 @@ static void fib6_del_route(struct fib6_node *fn, struct > rt6_info **rtp, > > fib6_purge_rt(rt, fn, net); > > + call_fib6_entry_notifiers(net, FIB_EVENT_ENTRY_DEL, rt); > if (!info->skip_notify) > inet6_rt_notify(RTM_DELROUTE, rt, info, 0); > rt6_release(rt); >
Why aren't all of the notifier calls under the skip_notify? That flag is used to make handling of ipv6 multipath routes on par with ipv4. See commit 3b1137fe74829