On 7/19/17 9:49 AM, Ido Schimmel wrote: > On Wed, Jul 19, 2017 at 09:27:30AM -0600, David Ahern wrote: >> On 7/19/17 1:02 AM, Jiri Pirko wrote: >>> Allow user space applications to see which routes are offloaded and >>> which aren't by setting the RTNH_F_OFFLOAD flag when dumping them. >>> >>> To be consistent with IPv4, a multipath route is marked as offloaded if >>> one of its nexthops is offloaded. Individual nexthops aren't marked with >>> the 'offload' flag. >> >> It is more user friendly to report the offload per nexthop especially >> given the implications. There are already flags per nexthop and those >> flags are pushed to userspace so not an API change at all. > > I thought about it, but then just decided to be consistent with IPv4.
And the comment stems from just that. I was looking at IPv4 ECMP routes a few days ago and the existence / lack of offload flag was not intuitive. > > I can send a follow-up patchset that aligns both families to the > behavior you requested. Need to teach iproute2 to look for > RTNH_F_OFFLOAD in rtnh_flags as well. >
