On Wed, Jun 20, 2018 at 07:02:41PM +0200, Davide Caratti wrote: ... > > I agree that we should update the drop counter, but given that > > you're already converting the stats to be per-cpu counters, whatever we > > add now will be just symbolic since you're going to change it anyway.
It wouldn't be symbolic. One thing is to convert a given increment into something else, another is to start increasing it for some (new) reason. > > that's ok for me also, as I can use the current v4 code for the rebase > (and not wait for another respin) _ but let's hear what reviewers think. > > > If > > reviewers think that Qiaobin's patch must add the update line, could you > > provide the exact line and location so we avoid going to v6 of this patch? > > In case, I was thinking of something like: > > https://elixir.bootlin.com/linux/v4.18-rc1/source/net/sched/act_ipt.c#L249 > > so, between 'err:' and 'spin_unlock(&d->tcf_lock)', insert a line like: > > d->tcf_qstats.drop++; I prefer the more complete version. Then it will have a more complete (git) history and help people when troubleshooting. Thanks, Marcelo
