On 08/20/2018 02:12 PM, Ahmad Fatoum wrote: > /* Loop over the child nodes and register a phy_device for each phy */ > for_each_available_child_of_node(np, child) { > + if (of_phy_is_fixed_link(np)) { > + /* fixed-links are handled in the MAC drivers */ > + dev_warn(&mdio->dev, FW_BUG > + "Skipping unexpected fixed-link in device > tree"); > + continue; > + } > +
This would emit the warning even for normal PHYs, because of_phy_is_fixed_link looks up a child... I will correct this in v3 along with any other potential suggestions.