On 08/20/2018 03:42 PM, Andrew Lunn wrote: > On Mon, Aug 20, 2018 at 02:12:37PM +0200, Ahmad Fatoum wrote: > This is correct. But i would prefer the more readable > > struct device_node *node = of_get_child_by_name(np, "mdio"); > > if (!node) > /* Allow for the deprecated PHYs in the MAC node. */ > node = np; > >> if (pdata) >> bp->mii_bus->phy_mask = pdata->phy_mask; >> - >> - err = of_mdiobus_register(bp->mii_bus, np); >> + err = of_mdiobus_register(bp->mii_bus, node); >> }
Ok. > Also, the device tree binding documentation needs updating. I've done so in part 4/4.
