On Mon, 15 Oct 2018 10:48:05 +0200 Nicolas Dichtel <nicolas.dich...@6wind.com> wrote:
> Le 12/10/2018 à 18:34, Stefano Brivio a écrit : > > On Fri, 12 Oct 2018 17:58:55 +0200 > > Nicolas Dichtel <nicolas.dich...@6wind.com> wrote: > [snip] > >> Could you explain in your commit log which problem your patch fixes? > > > > Nothing really. > > > > The change in f15ca723c1eb looked accidental and I thought it doesn't > > make sense to update the PMTU in that case, but I didn't figure out > > it's not actually done anyway. > > > > Maybe it makes things a bit more readable, in that case I'd target it > > for net-next. What do you think? > > > I don't think that this patch helps. The purpose of the skb_dst_update_pmtu() > helper is to hide those things. If one day, update_pmtu is defined for > md_dst_op, I bet that we won't remove this test. I see, makes sense. David, please drop this patch, and sorry for the noise. -- Stefano
