Use the kernel pointer that sctp_setsockopt has available instead of
directly handling the user pointer.

Signed-off-by: Christoph Hellwig <h...@lst.de>
---
 net/sctp/socket.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index a2aa1e309d595..e4b537e6d61da 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -3898,18 +3898,13 @@ static int sctp_setsockopt_paddr_thresholds(struct sock 
*sk,
        return 0;
 }
 
-static int sctp_setsockopt_recvrcvinfo(struct sock *sk,
-                                      char __user *optval,
+static int sctp_setsockopt_recvrcvinfo(struct sock *sk, int *val,
                                       unsigned int optlen)
 {
-       int val;
-
        if (optlen < sizeof(int))
                return -EINVAL;
-       if (get_user(val, (int __user *) optval))
-               return -EFAULT;
 
-       sctp_sk(sk)->recvrcvinfo = (val == 0) ? 0 : 1;
+       sctp_sk(sk)->recvrcvinfo = (*val == 0) ? 0 : 1;
 
        return 0;
 }
@@ -4691,7 +4686,7 @@ static int sctp_setsockopt(struct sock *sk, int level, 
int optname,
                                                          true);
                break;
        case SCTP_RECVRCVINFO:
-               retval = sctp_setsockopt_recvrcvinfo(sk, optval, optlen);
+               retval = sctp_setsockopt_recvrcvinfo(sk, kopt, optlen);
                break;
        case SCTP_RECVNXTINFO:
                retval = sctp_setsockopt_recvnxtinfo(sk, optval, optlen);
-- 
2.26.2

Reply via email to