Use the kernel pointer that sctp_setsockopt has available instead of
directly handling the user pointer.

Signed-off-by: Christoph Hellwig <h...@lst.de>
---
 net/sctp/socket.c | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 6136f863095ef..9173b1b80ee17 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -3992,27 +3992,21 @@ static int sctp_setsockopt_default_prinfo(struct sock 
*sk,
 }
 
 static int sctp_setsockopt_reconfig_supported(struct sock *sk,
-                                             char __user *optval,
+                                             struct sctp_assoc_value *params,
                                              unsigned int optlen)
 {
-       struct sctp_assoc_value params;
        struct sctp_association *asoc;
        int retval = -EINVAL;
 
-       if (optlen != sizeof(params))
-               goto out;
-
-       if (copy_from_user(&params, optval, optlen)) {
-               retval = -EFAULT;
+       if (optlen != sizeof(*params))
                goto out;
-       }
 
-       asoc = sctp_id2assoc(sk, params.assoc_id);
-       if (!asoc && params.assoc_id != SCTP_FUTURE_ASSOC &&
+       asoc = sctp_id2assoc(sk, params->assoc_id);
+       if (!asoc && params->assoc_id != SCTP_FUTURE_ASSOC &&
            sctp_style(sk, UDP))
                goto out;
 
-       sctp_sk(sk)->ep->reconf_enable = !!params.assoc_value;
+       sctp_sk(sk)->ep->reconf_enable = !!params->assoc_value;
 
        retval = 0;
 
@@ -4684,7 +4678,7 @@ static int sctp_setsockopt(struct sock *sk, int level, 
int optname,
                retval = sctp_setsockopt_default_prinfo(sk, kopt, optlen);
                break;
        case SCTP_RECONFIG_SUPPORTED:
-               retval = sctp_setsockopt_reconfig_supported(sk, optval, optlen);
+               retval = sctp_setsockopt_reconfig_supported(sk, kopt, optlen);
                break;
        case SCTP_ENABLE_STREAM_RESET:
                retval = sctp_setsockopt_enable_strreset(sk, optval, optlen);
-- 
2.26.2

Reply via email to