Thomas Graf <[EMAIL PROTECTED]> wrote: > When transmit fails with NETDEV_TX_LOCKED the skb is requeued > to dev->qdisc again. The dev->qdisc pointer is protected by > the queue lock which needs to be dropped when attempting to > transmit and acquired again before requeing. The problem is > that qdisc_restart() fetches the dev->qdisc pointer once and > stores it in the `q' variable which is invalidated when > dropping the queue_lock, therefore the variable needs to be > refreshed before requeueing. > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
I agree, good catch Thomas. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
