Hello. In article <[EMAIL PROTECTED]> (at Sat, 29 Sep 2007 10:04:48 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> says:
> In article <[EMAIL PROTECTED]> (at Fri, 28 Sep 2007 17:50:38 -0700), David > Stevens <[EMAIL PROTECTED]> says: > > > Brian, > > A multicast address should never be the target of a neighbor > > discovery request; the sender should use the mapping function for all > > multicasts. So, I'm not sure that your example can ever happen, and it > > certainly is ok to send ICMPv6 errors to multicast addresses in general. > > But I don't see that it hurts anything. either (since it should never > > happen :-)), > > so I don't particularly object, either. > > I think it'd also be better if you add the check to be: > > > > if (ipv6_addr_type(target) & > > (IPV6_ADDR_LINKLOCAL|IPV6_ADDR_UNICAST)) > > > > or something along those lines, rather than reproducing ipv6_addr_type() > > code > > separately in a new ipv6_addr_linklocal() function. I'm fine with the idea of the fix itself. Please use ipv6_addr_type() so far and convert other users as well to ipv6_addr_linklocal() in another patch. Regards, --yoshfuji - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
