On Sat, 29 Aug 2015 00:24:11 +0200, Thomas Graf wrote: > On 08/28/15 at 08:48pm, Jiri Benc wrote: > > diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c > > index e2dc9dac59e6..40164037928e 100644 > > --- a/net/openvswitch/vport.c > > +++ b/net/openvswitch/vport.c > > @@ -587,6 +587,8 @@ int ovs_tunnel_get_egress_info(struct ip_tunnel_info > > *egress_tun_info, > > > > if (unlikely(!tun_info)) > > return -EINVAL; > > + if (ip_tunnel_info_af(tun_info) != AF_INET) > > + return -EINVAL; > > > > tun_key = &tun_info->key; > > Are you sure this chunk is needed? It looks like OVS_CB()->egress_tun_info > can only be set via execute_set_action() which can only be of a supported > AF type.
It does no harm and I'm going to add IPv6 tunneling support to ovs soon. This is a nice reminder that this function is IPv4 only and needs to be extended. > Otherwise this looks great. > > Acked-by: Thomas Graf <tg...@suug.ch> Thanks! Jiri -- Jiri Benc -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
