From: Eric W. Biederman > Sent: 23 September 2015 03:15 > David Ahern <d...@cumulusnetworks.com> writes: > > > e_nobufs has 1 user. Move setting err to -ENOBUFS for the 1 user and > > use the goto out label instead of e_nobufs. Stepping stone patch; next > > one moves rth code into a helper function. > > Ick you are pessimizing the code. > > You will almost certainly have better code generation if you hoist > the assignment of "err = -ENOBUFS" above the rt_dst_alloc then you > don't need to do anything in your error path except "goto out;"
Unlikely to make a difference. The compiler is very likely to set 'err' before the conditional branch anyway. It will use an extra register to make it all work. David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html