Hi Tejun,

On 11/21/2015 05:14 PM, Tejun Heo wrote:> +static int
> cgroup_mt_check_v1(const struct xt_mtchk_param *par)
> +{
> +     struct xt_cgroup_info_v1 *info = par->matchinfo;
> +     struct cgroup *cgrp;
> +
> +     if ((info->invert_path & ~1) || (info->invert_classid & ~1))
> +             return -EINVAL;

The checks below use pr_info() in case the configuration is not valid.
Is this missing here on purpose?

I have tested it slightly and it seems to work (also on an older
kernel). I don't know if that qualifies it for a Tested-by but at least
Acked-by should do the trick:

Tested-by: Daniel Wagner <daniel.wag...@bmw-carit.de>
Acked-by: Daniel Wagner <daniel.wag...@bmw-carit.de>

cheers,
daniel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to