Pablo Neira Ayuso <pa...@netfilter.org> wrote:
> On Wed, Feb 07, 2018 at 02:48:22PM +0100, Florian Westphal wrote:
> > remove several pr_info messages that cannot be triggered with iptables.
> >
> > Signed-off-by: Florian Westphal <f...@strlen.de>
> > ---
> > net/ipv4/netfilter/ipt_ECN.c | 10 ++++------
> > net/netfilter/xt_HL.c | 13 +++----------
> > net/netfilter/xt_LED.c | 4 +---
> > net/netfilter/xt_cgroup.c | 4 +---
> > 4 files changed, 9 insertions(+), 22 deletions(-)
> >
> > diff --git a/net/ipv4/netfilter/ipt_ECN.c b/net/ipv4/netfilter/ipt_ECN.c
> > index 270765236f5e..39ff167e6d86 100644
> > --- a/net/ipv4/netfilter/ipt_ECN.c
> > +++ b/net/ipv4/netfilter/ipt_ECN.c
> > @@ -98,14 +98,12 @@ static int ecn_tg_check(const struct xt_tgchk_param
> > *par)
> > const struct ipt_ECN_info *einfo = par->targinfo;
> > const struct ipt_entry *e = par->entryinfo;
> >
> > - if (einfo->operation & IPT_ECN_OP_MASK) {
> > - pr_info("unsupported ECN operation %x\n", einfo->operation);
> > + if (einfo->operation & IPT_ECN_OP_MASK)
>
> According to patch 2/7, these should be pr_debug(), or probably I'm
> misunderstanding something :-).
Right, there is no consistency in the tree currently.
I don't think we'll see any new options added to ipt_ECN, so I don't
think its worth having a pr_foo() for this.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
