Dear all,
Here is my AD review of draft-ietf-netmod-yang-metadata-03. Only
editorial comments, except potentially the last point.
-
"data type", to which you refer in the terminology section, is not defined in
[I-D.ietf-netmod-rfc6020bis
<https://tools.ietf.org/html/draft-ietf-netmod-yang-metadata-03#ref-I-D.ietf-netmod-rfc6020bis>] terminology section.
-
"An annotation MUST NOT change the data tree semantics defined by
YANG."
We should be consistent between YANG modules versus YANG models versus YANG
data models versus YANG.
See my previous message on the list.
Here I believe we need:
"An annotation MUST NOT change the data tree semantics defined by
the YANG module".
-
OLD:
Copyright (c) 2015 IETF
NEW:
Copyright (c) 2016 IETF
-
The key words 'MUST', 'MUST NOT', 'REQUIRED', 'SHALL', 'SHALL
NOT', 'SHOULD', 'SHOULD NOT', 'RECOMMENDED', 'MAY', and
'OPTIONAL' in the module text are to be interpreted as described
inRFC 2119 <https://tools.ietf.org/html/rfc2119>
(http://tools.ietf.org/html/rfc2119).
This language in the YANG module is certainly a left over the draft version 1.
I don't see any RFC2119 in the module itself.
-
"The 'md:annotation' statement can appear only at the top level of a YANG
module."
I don't understand what the top is? You mean, after the import statements.
Should pyang check this? If yes, how?
From the example,
The following module defines the "last-modified" annotation:
module example-last-modified {
namespace"http://example.org/example-last-modified";;
prefix "elm";
import ietf-yang-types {
prefix "yang";
}
import ietf-yang-metadata {
prefix "md";
}
md:annotation last-modified {
type yang:date-and-time;
description
"This annotation contains date and time when the
annotated instance was last modified (or created).";
}
}
Regards, Benoit
_______________________________________________
netmod mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/netmod
