Hi Benoit, thanks for the review, please see my replies inline.
> On 24 Feb 2016, at 10:34, Benoit Claise <[email protected]> wrote: > > Dear all, > > Here is my AD review of draft-ietf-netmod-yang-metadata-03. Only editorial > comments, except potentially the last point. > - > "data type", to which you refer in the terminology section, is not defined in > [ > I-D.ietf-netmod-rfc6020bis > ] terminology section. The term "data type" certainly is defined in 6020bis, albeit not in the terminology section. > > > - > "An annotation MUST NOT change the data tree semantics defined by > YANG." > > We should be consistent between YANG modules versus YANG models versus YANG > data models versus YANG. > See my previous message on the list. > Here I believe we need: > "An annotation MUST NOT change the data tree semantics defined by > the YANG module". Actually, I think "YANG" is correct here, meaning "YANG the data modelling language". For example, an annotation cannot mean "this configuration list has no keys" because YANG specification doesn't allow it. This rule is written in 6020(bis), not in any YANG module. > > - > OLD: > Copyright (c) 2015 IETF > NEW: > Copyright (c) 2016 IETF OK, will fix, and also add Lou as the third WG chair. > > - > The key words 'MUST', 'MUST NOT', 'REQUIRED', 'SHALL', 'SHALL > NOT', 'SHOULD', 'SHOULD NOT', 'RECOMMENDED', 'MAY', and > 'OPTIONAL' in the module text are to be interpreted as described > in > RFC 2119 (http://tools.ietf.org/html/rfc2119 > ). > > This language in the YANG module is certainly a left over the draft version > 1. I don't see any RFC2119 in the module itself. > Right, I will remove this text from the module. > > > > - > "The 'md:annotation' statement can appear only at the top level of a YANG > module." > > I don't understand what the top is? You mean, after the import statements. What is means is "not inside definition of schema nodes." I will add such a clarification. > Should pyang check this? If yes, how? Yes, pyang could check it when parsing a module. The "dsdl" translator ignores this annotation unless it is at the top level. Thanks, Lada > >From the example, > > The following module defines the "last-modified" annotation: > > module example-last-modified { > namespace > "http://example.org/example-last-modified"; > ; > prefix "elm"; > import ietf-yang-types { > prefix "yang"; > } > import ietf-yang-metadata { > prefix "md"; > } > md:annotation last-modified { > type yang:date-and-time; > description > "This annotation contains date and time when the > annotated instance was last modified (or created)."; > } > } > > Regards, Benoit > > _______________________________________________ > netmod mailing list > [email protected] > https://www.ietf.org/mailman/listinfo/netmod -- Ladislav Lhotka, CZ.NIC Labs PGP Key ID: E74E8C0C _______________________________________________ netmod mailing list [email protected] https://www.ietf.org/mailman/listinfo/netmod
