On Wed, Sep 26, 2018 at 07:55:44AM -0700, Andy Bierman wrote:
> On Wed, Sep 26, 2018 at 7:40 AM joel jaeggli <[email protected]> wrote:
>
> > This is start of a two week poll on making
> > draft-ietf-netmod-module-tags-02 a NetMod working group
> > document.
> >
>
>
> I think we did this step already.
> https://www.ietf.org/mail-archive/web/netmod/current/msg20344.html
>
> Otherwise how would the draft be named draft-ietf-netmod?
> Maybe you mean to start a WGLC, which I also support.
>
While we figure out what the action is, here are a few quick review
comments:
- What does this mean? In particular the second sentence makes me wonder.
Implementations MUST ensure that a modules tag list is consistent
across any location from which the list is accessible. So if a user
adds a tag through configuration that tag should also be seen when
using any augmentation that exposes the modules tag list.
- Wording - suggest to remove 'types':
Tags may be IANA assigned or privately defined types.";
- Leaf names:
module: ietf-module-tags
+--rw module-tags* [name]
+--rw name yang:yang-identifier
+--rw tag* string
+--rw masked-tag* string
Name seems to refer to a module but this is not clear until you
read the description. I understand that in RFC 7895 and its bis we
also just use 'name' but I would find things easier to understand
if we would have this:
module: ietf-module-tags
+--rw module-tags* [module]
+--rw module yang:yang-identifier
+--rw tags* string
+--rw masked-tags* string
Note that I also used plural for the leaf-lists.
In the description, I would also say "A list of tags associated
with..." instead of "A tag associated with...".
- Editorial
s/This user/A user
- Adding and masking the same tag
What happens if config adds a tag and masks the same tag? Is the
masking taking priority in this case, i.e., you first all all tags
and then you filter those that are masked?
- Standard tags defined in description statements
I do not like this. YANG has extension statements and having to
parse stuff out of free text description statements seems to be a
movement backwards.
- System management
What is 'system management' and a 'system management protocol'?
- Tag format
Apparently, the colon has a special meaning in a tag string and
otherwise there do not seem to be any restrictions. (Which is good,
I can finally put various smileys on my gear.)
Should we state explicitly somewhere that a colon has a special
meaning and that tag strings are structured into a sequence of
'taggies' separated by colons? Or is definition by example good
enough?
- Meaning of tag masks
Do masks mean a complete string match or can I mask along the prefix
hierarchy, i.e., 'vendor:acme:' masks everything starting with
'vendor:acme:'?
- Retrieval of the final list of tags
Once I have configured tags and masks, how do I obtain the resulting
tag list? Do I have to calculate this locally? Or will the final
list be found in the operational state datastore (i.e., the applied
config
/js
--
Juergen Schoenwaelder Jacobs University Bremen gGmbH
Phone: +49 421 200 3587 Campus Ring 1 | 28759 Bremen | Germany
Fax: +49 421 200 3103 <https://www.jacobs-university.de/>
_______________________________________________
netmod mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/netmod
