Martin Bjorklund <[email protected]> wrote:
> Hi,
>
> Some comments inline.
>
>
> "Rob Wilton (rwilton)" <[email protected]> wrote:
> > Hi Vladimir,
> >
> > Thanks for your detailed review. Sorry for the slow reply, I've been
> > away. I'm also about to be away again for a couple of days.
> >
> > Please see my comments inline ...
> >
> > I'll also track these issues to closure on
> > https://github.com/netmod-wg/interface-extensions-yang/issues
> >
> > > -----Original Message-----
> > > From: netmod <[email protected]> On Behalf Of Vladimir Vassilev
[...]
> > > 19. ietf-if-common.yang and ietf-if-ethernet-like.yang instead of
> > > ietf-
> > > interfaces-common.yang and ietf-interfaces-ethernet-like.yang.
> > > Setting a shorter naming precedent for future modules augmenting ietf-
> > > interfaces.
> >
> > I'm not opposed to shorter names, but would be interested in the views
> > of others in the WG.
>
> I had a similar concern for the modules in the sub-intf-vlan draft (I
> will post my review of that doc later).
>
> Currently we have:
>
> ietf-interfaces-common
> ietf-interfaces-ethernet-like
> ietf-if-l3-vlan
> ietf-flexible-encapsulation
>
> I think we should have consistency, either:
>
> ietf-interfaces-common
> ietf-interfaces-ethernet-like
> ietf-interfaces-l3-vlan
> ietf-interfaces-flexible-encapsulation
>
> or
>
> ietf-if-common
> ietf-if-ethernet-like
> ietf-if-l3-vlan
> ietf-if-flexible-encapsulation
One comment re naming here.
The name "ietf-interfaces-common" seems a bit odd; isn't
"ietf-interfaces" for "common" definitions?
I was going to suggest "ietf-interfaces-extensions", but then I
re-read the description in the module:
This module contains common definitions for extending the IETF
interface YANG model (RFC 8343) with common configurable layer 2
properties.
So perhaps "ietf-interfaces-l2-extensions" would be better?
.... but then "forwarding-mode" isn't a l2 property.
/martin
_______________________________________________
netmod mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/netmod
