Hi Eric, > On Sep 4, 2024, at 12:30 PM, Eric Vyncke (evyncke) <evyn...@cisco.com> wrote: > > Mahesh and Joe, > > Thanks for your prompt replies. > > Understood for NETMOD vs. OPSAWG (both charters allow it anyway, a strange > overlap though). > > Agreed on all the proposed changes, they make the text better. > > Now, about the tree representation, I wonder how it could be improved by > clearly delineating the grouping and imported branches... Was there any > project in NETMOD about this ?
Not really. The interest was always to show a fully expanded tree diagram. There is an option to print the tree diagram without expanding the groupings, but then you will see just the name of the grouping without knowing what is being included as part of the grouping. We erred on the side of showing what is included. Thanks. > > Regards > > -éric > > From: Mahesh Jethanandani <mjethanand...@gmail.com > <mailto:mjethanand...@gmail.com>> > Date: Wednesday, 4 September 2024 at 19:41 > To: Eric Vyncke (evyncke) <evyn...@cisco.com <mailto:evyn...@cisco.com>> > Cc: The IESG <i...@ietf.org <mailto:i...@ietf.org>>, > draft-ietf-netmod-syslog-mo...@ietf.org > <mailto:draft-ietf-netmod-syslog-mo...@ietf.org> > <draft-ietf-netmod-syslog-mo...@ietf.org > <mailto:draft-ietf-netmod-syslog-mo...@ietf.org>>, NETMOD WG Chairs > <netmod-cha...@ietf.org <mailto:netmod-cha...@ietf.org>>, NETMOD Working > Group <netmod@ietf.org <mailto:netmod@ietf.org>>, Lou Berger > <lber...@labn.net <mailto:lber...@labn.net>>, Kent Watsen > <kent+i...@watsen.net <mailto:kent+i...@watsen.net>> > Subject: Re: Éric Vyncke's No Objection on draft-ietf-netmod-syslog-model-32: > (with COMMENT) > > [Speaking as an author] > > Hi Eric, > > > On Sep 4, 2024, at 2:32 AM, Éric Vyncke via Datatracker <nore...@ietf.org > <mailto:nore...@ietf.org>> wrote: > > Éric Vyncke has entered the following ballot position for > draft-ietf-netmod-syslog-model-32: No Objection > > When responding, please keep the subject line intact and reply to all > email addresses included in the To and CC lines. (Feel free to cut this > introductory paragraph, however.) > > > Please refer to > https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ > <https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/> > > for more information about how to handle DISCUSS and COMMENT positions. > > > The document, along with other ballot positions, can be found here: > https://datatracker.ietf.org/doc/draft-ietf-netmod-syslog-model/ > <https://datatracker.ietf.org/doc/draft-ietf-netmod-syslog-model/> > > > > ---------------------------------------------------------------------- > COMMENT: > ---------------------------------------------------------------------- > > Thanks for the work done in this document, I have nevertheless some > non-blocking comments (see below) and I am also curious why this document was > done in NETMOD rather than OPSAWG (as it seems that many YANG models are > authored in OPSAWG even if NETMOD charter would allow it). > > The document has a long history, starting back in 2014. The reason (partly) > for keeping it in NETMOD at the time when the work started was because most > of the YANG experts were active in NETMOD more than OPSAWG. If we were to > look at it today, you are probably right, the document would have more likely > been done in OPSAWG. > > > > # Meta data > > Should Mahesh's new affiliation be specified ? > > The bulk of the work was done when I was affiliated with Kloud, which BTW is > still active, and therefore decided to keep the affiliation. > > > > # Abstract and title > > It is unclear that the YANG model is only for the collector part of syslog. > > That is correct. Would it help if the word collector was used? Something like > > OLD: > It is intended this model be used by vendors who implement syslog in their > systems. > > NEW: > It is intended this model be used by vendors who implement syslog collector > in their systems. > > > > # Section 1 > > What is the `target system` ? At first reading, it seems to be the collector > system, if so, should the I-D be consistent in vocabulary ? > > Ok. How about this? > > OLD: > This module can be used to configure the syslog application conceptual layers > as implemented on the target system. > > NEW: > This module can be used to configure the syslog application conceptual layers > as implemented on the syslog collector. > > > > # Section 5.1 > > While I am not a YANG expert, isn't it weird to replicate the facility-filter > under console, remote, and file ? Or is it just a caveat of the tree diagram > when it expands the facility-filter grouping several times ? > > Yes, what you are seeing is an expansion of the grouping called ‘selector’ > used each time for facility of console, remote and file. > > > > Would it be possible to import TLS and authentication from other YANG models ? > > It does indeed import groupings from ietf-tls-client module defined in > draft-ietf-netconf-tls-client-server module, and is the reason why it has > taken this draft all this time to come forth for publication. > > Thanks. > > > > > > > > Mahesh Jethanandani > mjethanand...@gmail.com <mailto:mjethanand...@gmail.com> Mahesh Jethanandani mjethanand...@gmail.com
_______________________________________________ netmod mailing list -- netmod@ietf.org To unsubscribe send an email to netmod-le...@ietf.org
