On 2015-06-10 at 15:34:03 +0200, Vadim Kochan <[email protected]> wrote: > On Wed, Jun 10, 2015 at 03:29:17PM +0200, Tobias Klauser wrote: > > On 2015-06-10 at 12:31:50 +0200, Vadim Kochan <[email protected]> wrote: > > > From: Vadim Kochan <[email protected]> > > > > > > Add suporting Linux "cooked" header: > > > > > > http://www.tcpdump.org/linktypes/LINKTYPE_NETLINK.html > > > > > > Added -w,--cooked option which replaces L2 header frame with cooked > > > header for each frame and allows to dump & dissect Ethernet & Netlink > > > packets together. > > > > > > Added dissector_sll.c to dissect packets with Linux "cooked" header. > > > Meanwhile it can dump only Netlink & Ethernet protos (L3 layer). This > > > dissector is used if link type is LINKTYPE_LINUX_SLL. > > > > This should be a patch on its own. > > > > > Used dgram packet socket when sniffing with "--cooked" option > > > to pull L2 header and wrap packet with Linux "cooked" header, it allows > > > compatibility with Wireshark. > > > > > > Moved some device's stuff string conversion functions from proto_nlmsg.c > > > to dev.c to be used also in dissector_sll.c > > > > This as well. > > > > Could you please split this patch up into a series and resend: > > > > 1. Moving device string conversion functions from proto_nlmsg.c to dev.c > > 2. SLL dissector > > 3. Cooked header functionality (including man page changes) > > > > This will make it easier to review and dissect. > > I will try ... but actually Daniel asked me to have this "cooked" staff > in one patch - if I am correct: > Below is a piece of dialog between me and Daniel: > > ----------- > Me said: > > OK, but it sounds like "--cooked" option might be as additional feature > > so I think the current patch can be applied as it is ? I have no problem > > with re-working the patch, I am just asking :) > > Daniel answered: > Ok, sure. I would prefer to have this in a single patch, so would be glad if > you could respin/rework your patch towards this. > > Thanks again, > Daniel > ----------- > > Or I misunderstood Daniel ?
Ok, I didn't get that part of the conversation (probably happened during my holidays). As I interpret his answer, he's just referring to the additional command line option. The moving of functions and the new dissector weren't part of the game then, no? In any case, I'll wait for Daniel's comment and if he thinks it's fine as a single patch, I'll review it as such (after all it's just personal preference that I like patches as fine grained as possible ;-) Thanks -- You received this message because you are subscribed to the Google Groups "netsniff-ng" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
