On 06/12/2015 04:20 PM, Vadim Kochan wrote:
On Wed, Jun 10, 2015 at 11:32:49PM +0200, Daniel Borkmann wrote:
On 06/10/2015 03:53 PM, Tobias Klauser wrote:
...
Ok, I didn't get that part of the conversation (probably happened during
my holidays). As I interpret his answer, he's just referring to the
additional command line option. The moving of functions and the new
dissector weren't part of the game then, no?
Sorry for the late answer (on vacation), and thanks for the rework!
In any case, I'll wait for Daniel's comment and if he thinks it's fine
as a single patch, I'll review it as such (after all it's just personal
preference that I like patches as fine grained as possible ;-)
I indeed didn't expect a dissector for cooked pcaps, but it's great you've
implemented it, Vadim! I'm fine either way, but given the size, it'll take
couple of evenings to review it, so stay tuned.
Thanks,
Daniel
OK, so I will try to split this patch into 3 pieces.
I think that would be great, thanks Vadim!
--
You received this message because you are subscribed to the Google Groups
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
