On Mon, Aug 8, 2016 at 5:24 PM, Tobias Klauser <tklau...@distanz.ch> wrote: > On 2016-08-06 at 11:59:05 +0200, Vadim Kochan <vadi...@gmail.com> wrote: >> On Sat, Aug 6, 2016 at 12:41 PM, Tobias Klauser <tklau...@distanz.ch> wrote: >> > On 2016-08-05 at 22:51:54 +0200, Vadim Kochan <vadi...@gmail.com> wrote: >> >> Hm, >> >> >> >> My version was to keep current strict dependency on libnl by default, >> >> so if there is no libnl then >> >> netsniff-ng & trafgen will be removed from build list, but make >> >> possible to skip this >> >> rule by --disable-libnl option. Now I am not sure there is a reason >> >> for --disable-libnl as if there is no libnl >> >> then netsniff-ng & trafgen will be added to build list, and will be >> >> compiled w/o libnl dependency.. >> > >> > Ok, but that intention of your patch wasn't really clear from the >> > description, sorry. >> >> Yes, usually I put no so much description into patches. > > Please try to be as verbose as possible in patch descriptions (at least > for non-trivial patches). The description is there to help others > understand the rationale behind a patch (before applying it and > especially afterwards e.g. when chasing bugs). > >> >> So does --disable-libnl makes sense ? >> > >> > If you have libnl-dev installed but want to compile netsniff-ng/trafgen >> > without libnl support it still makes sense. >> > >> > IMO the current version is more in line with the behavior we already >> > have for geoip and libz. >> > >> > Thanks >> > Tobias >> >> Yes, I understand, I said so because I really remember we talked about >> disabling of libnl support earier ago and you or Daniel pointed that >> it is better to have this dependency by default, this is how I >> remember this, I might be wrong, but anyway >> it simplifies build netsniff-ng/trafgen manually w/o searching libnl- >> packages on specific dist. > > I can't remember we talked about it, but that doesn't mean we didn't :) > In any case if we discussed a particular feature/patch/RFC/... before > and you patch is based on the previous discussion, please include a link > to the respective mailing list thread into the description. This may > help to remind us of past conversations ;) > > Thanks!
This is a link with our discussion (within libnl-route fix titled with "[PATCH] build: Check for libnl-route"), but I looked for this just now so I did not consider it while writing previous email, so I might be wrong for some conclusions): https://groups.google.com/forum/?hl=en#!searchin/netsniff-ng/Check$20for$20libnl-route%7Csort:relevance/netsniff-ng/0Ws7ecy1H_Y/DIzprE4KBAAJ -- You received this message because you are subscribed to the Google Groups "netsniff-ng" group. To unsubscribe from this group and stop receiving emails from it, send an email to netsniff-ng+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
