Here are my own comments on Mike's stuff. They're mostly related to user interface intuitiveness, aesthetics and consistency. I'm quite fastidious about these things for RISC OS apps, but I am far less familiar with GTK, so some of my suggestions might not be right.
About NetSurf window -------------------- + I'd prefer the link to be "The NetSurf web site" or simply the URL "http://www.netsurf-browser.org/";. Many apps seem to use the URL, which seems good because you know exactly where it'll take you. + Other apps have a "Licence" button next to the "Credits" one. I think this would be good to have for consistency. Also if NetSurf is packaged it may not come with the COPYING file that's in SVN. + I did this in trunk http://source.netsurf-browser.org/?view=rev&revision=4330 Perhaps you should do the same in the branch. Preferences window ------------------ + When "Simple proxy" is selected, the Username and Password fields should be grayed out. Main browser window ------------------- + It would be good to remove the minimum browser window width. As per http://vlists.pepperfish.net/pipermail/netsurf-dev-netsurf-browser.org/2008-February/000308.html + The local history window is quite a useful and unique feature. At the moment it's a bit hidden in the menu. Could we have a toolbar icon for it? I'm against having loads of icons on the toolbar in general, but I think we could get away with a little downwards pointing triangle button after [back] [forward]. That button could open the local history window, similar to how Firefox 3 has a similar button to open a list of pages in the history. Download window --------------- + When the download has unknown total size, the progress bar makes it look like the download is complete. I suggest having a moving short bar, when the download has unknown total size. So, if a normal download does this: | | |- | |-- | |--- | |---- | |-----| Then an unknown-length download should cycle like this: |-- | | -- | | -- | | --| | -- | | -- | etc... + Obviously the combined progress bar at the bottom needs implemented and it should behave like the unknown-length one if there are any unknown-length downloads in progress. + If there is no selection, Clear should clear all inactive downloads. + The progress bar could be a bit wider. Currently when the download is complete, the text "Complete" touches the edges of the progress bar area. It would look better with a few pixels padding. + All the active downloads currently include the word "completed", which looks strange. I'd change it to "Fetched X.XX XB of X.XX XB" or just "X.XX XB of X.XX XB". + The window keeps growing as you get more downloads. It should stay the same size and gain a scrollbar. I'd prefer the new downloads to be at the top. + There is an odd border where the buttons are at the bottom of the window, which looks wrong. Should it go to the window's edge? Need they be there at all? See http://www.smoothartist.com/netsurf/gtkborders.png Also there is this warning: COMPILE: desktop/textinput.c desktop/textinput.c: In function 'browser_window_input_callback': desktop/textinput.c:869: warning: unused variable 'form_offset' Also, It would be good to split the Glade file into one file per window. Currently it's impossible to see what's change in the Glade file from the diff, because it seems to move everything around each time it's edited. If we had one file per window, it might help narrow what's actually changed down a bit. Otherwise, I think your progress has been brilliant so far; my comments are really pretty trifling. Best regards, Michael -- Michael Drake (tlsa) http://www.netsurf-browser.org/
