In message <55162516f4webpa...@sprow.co.uk>
Sprow <webpa...@sprow.co.uk> wrote:
>After some invaluable hand holding from Rob Kendrick (I failed to locate the
>instructions to set up a VM to build for RISC OS) I went ahead and wrote
>patches for
>
> http://bugs.netsurf-browser.org/mantis/view.php?id=2266
> http://bugs.netsurf-browser.org/mantis/view.php?id=2170
> http://bugs.netsurf-browser.org/mantis/view.php?id=2336
> http://bugs.netsurf-browser.org/mantis/view.php?id=2289
>
>but they presumably need reviewing. I know from a day job in engineering not
>to review my own code!
Please forgive my tardiness.
Bug 2266: I'm happy with the GUI patch. As for the language patch:
Wikipedia suggests that two letters are not always enough for the
language abbreviation. Sometimes three are necessary. Along with
the slash and a terminator, I'd suggest that a 4 character buffer
for langdir is not entirely future-proof - and the extra cost of
even an 8 character buffer is minimal - so how about a bigger
reservation? In other respects I'm happy.
Dave
____________________________________________________________
Receive Notifications of Incoming Messages
Easily monitor multiple email accounts & access them with a click.
Visit http://www.inbox.com/notifier and check it out!
