Nikos Mavrogiannopoulos <[email protected]> writes:

> The fat-arm build fails with:
>
> fat-arm.c: In function 'fat_init':
> fat-arm.c:194:7: error: '_nettle_sha1_compress_vec' undeclared (first
> use in this function); did you mean 'nettle_sha1_compress_vec'?
>        _nettle_sha1_compress_vec = _nettle_sha1_compress_armv6;
>        ^~~~~~~~~~~~~~~~~~~~~~~~~
>        nettle_sha1_compress_vec
> fat-arm.c:194:7: note: each undeclared identifier is reported only
> once for each function it appears in
> Makefile:258: recipe for target 'fat-arm.o' failed
> make[1]: *** [fat-arm.o] Error 1

I've noticed the same in a local cross-compilation environment. I'm
about to check in the fixes.

> btw. Note that fat-arm.c capabilities detection can be simplified with
> getauxval:
>
> https://community.arm.com/android-community/b/android/posts/runtime-detection-of-cpu-features-on-an-armv8-a-cpu

Ok, maybe we should revisit that. When I wrote the current code, which
is a few years ago now, I think I considered using getauxval, but
concluded that it was less portable than reading /proc/cpuinfo. (And
nettle currently only has arm-specific code for 32-bit arm; portability
considerations for 64-bit arm may be different since there's less old
stuff to care about).

Regards,
/Niels

-- 
Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677.
Internet email is subject to wholesale government surveillance.
_______________________________________________
nettle-bugs mailing list
[email protected]
http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs

Reply via email to