On Thu, 2018-07-12 at 10:31 +0200, Niels Möller wrote:
> 
> > btw. Note that fat-arm.c capabilities detection can be simplified
> > with
> > getauxval:
> > 
> > https://community.arm.com/android-community/b/android/posts/runtime
> > -detection-of-cpu-features-on-an-armv8-a-cpu
> 
> Ok, maybe we should revisit that. When I wrote the current code,
> which
> is a few years ago now, I think I considered using getauxval, but
> concluded that it was less portable than reading /proc/cpuinfo. (And
> nettle currently only has arm-specific code for 32-bit arm;
> portability
> considerations for 64-bit arm may be different since there's less old
> stuff to care about).

The main problem with the /proc/cpuinfo was that in the qemu-user
environment this is not emulated, and thus you'll be reading the CI
server's cpu information. We could work-around that by setting multiple
environment overrides during make check to ensure all code paths are
run.

regards,
Nikos

_______________________________________________
nettle-bugs mailing list
[email protected]
http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs

Reply via email to