Hello

Current status update

Le 2021-03-06 à 11 h 27, Niels Möller a écrit :

       // A = MSB(64, B) ^ t where t = (n*j)+i
       A64 = READ_UINT64(B.b);
       A64 ^= (n*j)+(i+1);
       WRITE_UINT64(A.b, A64);

I've added 2 macros definitions: MSB_XOR_T_WRAP and MSB_XOR_T_UNWRAP, I couldn't find how to make just one macro for both cases because of the direction of the xor.

I have the same problem with B.u64 being an array

.u64[0] for bytes 0--7, .u64[1] for bytes 8--15.

OK, I can set all .u64[0], but when it comes to .u64[1], I have a different behavior, example:

memcpy (I.b + 8, R + (i * 8), 8); // This one works
I.u64[1] = *(R + (i * 8)); // This one doesn't work

Is there something I'm missing?

I agree, I've updated the indentation using gnu indent with gnu style

Thanks. One peculiarity with the gnu style is the space between function
name and open parenthesis (which you have after reindent). Nettle isn't
quite consistent, but new code mostly follows this convention.

No problem, keeping the code style consistent is very important for maintenance.

/Nicolas

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
nettle-bugs mailing list
[email protected]
http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs

Reply via email to