Hello, Le 2021-03-28 à 11 h 10, Niels Möller a écrit :
Hi, I haven't been paying attention to this for a few weeks, but I've had a nother look now. I've left a few comments on the MR.
Thanks, I've made the requested changes in the MR.
No problem, I'll add more test cases with expected errors on unwrap. I'll also make changes to fit the convention if needed. (I used aes-test.c as starting point to write the aes-keywrap-test.c)For testing, it's important to test both in-place operation (that should be supported, right? Following the conventions documented at https://www.lysator.liu.se/~nisse/nettle/nettle.html#Conventions), and separate input and output area. For the tests of unwrap, it is important to test the error case, i.e., try changing some bit in the input, and verify that unwrap returns an error.
The new feature also needs documentation, will you look into that once code, and in particular the interfaces, are solid?
Definitely!What do you think the documentation should look like? Should it be near paragraph 7.2.1? Like
7.2.1.1 AES Key Wrap /Nicolas
OpenPGP_signature
Description: OpenPGP digital signature
_______________________________________________ nettle-bugs mailing list [email protected] http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
