I've mentioned it in the README file.

---
 arm64/README                   | 7 +++++++
 arm64/crypto/sha1-compress.asm | 6 ------
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/arm64/README b/arm64/README
index d2745d57..206bb773 100644
--- a/arm64/README
+++ b/arm64/README
@@ -83,5 +83,12 @@ particular care must be taken if the loaded data is then
to be regarded as
 elements of e.g. a doubleword vector. Indicies may appear reversed on
 big-endian systems (because they are).

+Hardware-accelerated SHA Instructions
+
+The SHA optimized cores are implemented using SHA hashing instructions
added
+to AArch64 in crypto extensions. The repository [3] illustrates using those
+instructions for optimizing SHA hashing functions.
+
 [1]
https://github.com/ARM-software/abi-aa/releases/download/2020Q4/aapcs64.pdf
 [2] https://llvm.org/docs/BigEndianNEON.html
+[3] https://github.com/noloader/SHA-Intrinsics
diff --git a/arm64/crypto/sha1-compress.asm b/arm64/crypto/sha1-compress.asm
index bb3f1d35..f261c93d 100644
--- a/arm64/crypto/sha1-compress.asm
+++ b/arm64/crypto/sha1-compress.asm
@@ -3,12 +3,6 @@ C arm64/crypto/sha1-compress.asm
 ifelse(`
    Copyright (C) 2021 Mamone Tarsha

-   Based on sha1-arm.c - ARMv8 SHA extensions using C intrinsics of
-   repository https://github.com/noloader/SHA-Intrinsics
-   sha1-arm.c is written and placed in public domain by Jeffrey Walton,
-   based on code from ARM, and by Johannes Schneiders, Skip
-   Hovsmith and Barry O'Rourke for the mbedTLS project.
-
    This file is part of GNU Nettle.

    GNU Nettle is free software: you can redistribute it and/or

-- 
2.25.1

On Thu, May 20, 2021 at 9:44 PM Maamoun TK <[email protected]>
wrote:

> On Thu, May 20, 2021 at 9:16 PM Niels Möller <[email protected]> wrote:
>
>> Maamoun TK <[email protected]> writes:
>>
>> > I've written the patch from scratch while keeping in mind how to use the
>> > SHA-1 instructions of Arm64 crypto extension from sha1-arm.c in
>> Jeffrey's
>> > repository.
>>
>> If that is the case, avoid phrases like "based on" which are easily
>> misread as implying it's a derived work in the copyright sense.
>>
>
> I'll just mention it in the README file then.
>
> regards,
> Mamone
>
_______________________________________________
nettle-bugs mailing list
[email protected]
http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs

Reply via email to